Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add justfile and nuke build.rs #219

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Add justfile and nuke build.rs #219

merged 5 commits into from
Apr 24, 2024

Conversation

Ottatop
Copy link
Collaborator

@Ottatop Ottatop commented Apr 23, 2024 •
edited
Loading

Decided on using just instead of make because it's oh so new and shiny. Also it's written in Rust™️

Closes #214 and unblocks #215

Ottatop added 5 commits April 24, 2024 18:33
@Ottatop
Add justfile
1d07e2a 
Need to add installs for root user
@Ottatop
Add root installs
29363c3 
NOTE: Pinnacle currently does not search root dirs for stuff like the protobuf definitions, this is just for packaging and stuff
@Ottatop
README: include just usage
827ce1e
@Ottatop
Obliterate build.rs
9f4b1a0
@Ottatop
Fix tests
36a8224 
Unwrap in tests to check error

Add backtrace to debug tests

Add dbg

i hate this

debugging github actions is a pain

aaaa

aaaaaaaaa

needs to be rebased
@Ottatop Ottatop marked this pull request as ready for review April 24, 2024 23:46
@Ottatop Ottatop merged commit 9f97fab into main Apr 24, 2024
4 checks passed
@Ottatop Ottatop deleted the justfile branch April 24, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build.rs engages in undefined behavior
1 participant
@Ottatop