Embed default rust config in binary #216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR embeds the default Rust config into the binary, meaning that Pinnacle no longer needs to run a separate process for the default config. It removes the hard dependency on Luarocks. This is halfway to resolving #214 and unblocking #215; the other half is to create a Makefile or some other external runner to copy over protobuf definitions and default configs for
pinnacle config gen
, but that's for another PR/commit.This does mean that users who want to use the Lua API will need to manually
cd
intoapi/lua
and runluarocks make [--local]
. Edit: Or stick that in the Makefile maybe idk my brain's fried rnAlso build times went up by like 9% :P. I considered locking the embedding behind a feature flag to mitigate this for Lua users, but I think it's cleaner if Pinnacle doesn't hard require a separate process and library to run.
TODO:
ignore the error? idkOption::take
the receiver when reloading the config to drop itbuild.rs
--no-config