Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default tab in settings with update to Feed to Recent #631

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

msamgan
Copy link
Contributor

@msamgan msamgan commented Sep 19, 2024

#454

image --
Screen.Recording.2024-09-19.at.11.40.57.AM.mov

@msamgan msamgan changed the title added default tab in settings and web. added default tab in settings. Sep 19, 2024
@msamgan msamgan marked this pull request as ready for review September 19, 2024 15:29
@msamgan
Copy link
Contributor Author

msamgan commented Sep 19, 2024

@nunomaduro @MrPunyapal please have a look.

tests/Http/Profile/EditTest.php Outdated Show resolved Hide resolved
routes/web.php Outdated Show resolved Hide resolved
routes/web.php Outdated Show resolved Hide resolved
app/Enums/HomePageTabs.php Outdated Show resolved Hide resolved
app/Enums/HomePageTabs.php Outdated Show resolved Hide resolved
@msamgan
Copy link
Contributor Author

msamgan commented Sep 21, 2024

All the requested changes has been made.

image

@msamgan msamgan changed the title added default tab in settings. added default tab in settings with update to Feed to Recent Sep 21, 2024
@msamgan msamgan changed the title added default tab in settings with update to Feed to Recent Added default tab in settings with update to Feed to Recent Sep 21, 2024
@msamgan
Copy link
Contributor Author

msamgan commented Sep 22, 2024

@nunomaduro anything else you want me to update in this one?

@msamgan
Copy link
Contributor Author

msamgan commented Sep 29, 2024

where are we on this one ?

Copy link
Collaborator

@CamKem CamKem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the PR locally, looks good.

I think adding the following change to navigation.blade.php home icon, would really enhance this feature. I find myself clicking on the home button when I go from someones profile back to the feeds, so I feel it's important to reflect the users choice when clicking the home button.

@php($defaultTab = auth()?->user()->default_tab ?? 'recent')
<a
    title="Home"
    href="{{ route("home.{$defaultTab}") }}"
    class=""
    wire:navigate
>

@MrPunyapal Wdyt?

@MrPunyapal
Copy link
Collaborator

Agreed!

@msamgan
Copy link
Contributor Author

msamgan commented Oct 5, 2024

$defaultTab = auth()?->user()->default_tab ?? 'recent'

Updated.

@msamgan
Copy link
Contributor Author

msamgan commented Oct 9, 2024

@CamKem, the requested changes have been made, can you please approve the changes if there is nothing needs to be added?

@MrPunyapal
Copy link
Collaborator

@msamgan can you rebase?

@msamgan
Copy link
Contributor Author

msamgan commented Oct 22, 2024

@msamgan can you rebase?

@MrPunyapal "data-pan="home-tabs-feed"" should i change this to "data-pan="home-tabs-recent" ?

@msamgan
Copy link
Contributor Author

msamgan commented Oct 22, 2024

all done...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants