Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/crypto: replace 'math/rand' with 'crypto/rand' #2455

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Aug 28, 2024

What problem does this PR solve?

Replace math/rand with crypto/rand, which resolve some potential security vulnerability issue according to some third-party security scanners.

What is changed and how it works?

As described.

Check List

Tests

  • No code

Code changes

  • Has interface methods change

Side effects

  • None

Related changes

  • None

Release notes:

NONE

Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bb7133, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 28, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 28, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-28 06:21:03.392835948 +0000 UTC m=+937658.527286064: ☑️ agreed by xhebox.

@xhebox xhebox merged commit a16d04f into pingcap:master Aug 28, 2024
18 of 20 checks passed
@bb7133 bb7133 deleted the bb7133/crypto branch August 28, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants