Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: Allow specifying port offset #2453

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Aug 20, 2024

What problem does this PR solve?

What is changed and how it works?

Sometimes we want to start multiple clusters concurrently (and also preserve them).

Preserving data is possible by specifying --tag.

But multiple co-exist clusters will meet issues after restart because dynamic port may be changed and stores are regarded as new stores.

This PR adds --port-offset so that this could work nicely, e.g:

  • Cluster1: --tag=cluster1 --port-offset=10000
  • Cluster2: --tag=cluster2 --port-offset=20000

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Copy link
Contributor

ti-chi-bot bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-20 05:34:21.741570159 +0000 UTC m=+243656.876020281: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 20, 2024
@xhebox xhebox merged commit b5bd3bb into master Aug 20, 2024
19 of 20 checks passed
@xhebox xhebox deleted the wenxuan/port-offset branch August 20, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants