Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiflash: Add example of setting the tiflash-proxy configs #2444

Merged

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Jul 24, 2024

What problem does this PR solve?

Finding out how to set the tiflash-proxy configs in tiup is hard.

What is changed and how it works?

Add example of setting the tiflash-proxy configs

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: JaySon-Huang <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from srstack July 24, 2024 10:08
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 24, 2024
@JaySon-Huang
Copy link
Contributor Author

/cc @CalvinNeo @xhebox

@ti-chi-bot ti-chi-bot bot requested a review from xhebox July 24, 2024 10:12
Copy link
Contributor

ti-chi-bot bot commented Jul 24, 2024

@JaySon-Huang: GitHub didn't allow me to request PR reviews from the following users: CalvinNeo.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @CalvinNeo @xhebox

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-24 10:23:58.110066509 +0000 UTC m=+1040660.101007978: ☑️ agreed by xhebox.

Copy link
Contributor

ti-chi-bot bot commented Jul 24, 2024

@Lloyd-Pottiger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

ti-chi-bot bot commented Jul 24, 2024

@CalvinNeo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JaySon-Huang
Copy link
Contributor Author

/retest

1 similar comment
@JaySon-Huang
Copy link
Contributor Author

/retest

@xhebox xhebox merged commit 3b92a56 into pingcap:master Jul 25, 2024
19 of 20 checks passed
@JaySon-Huang JaySon-Huang deleted the add_example_of_tiflash_proxy_config branch July 25, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants