Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: Improve cluster restart messaging #2442

Merged
merged 1 commit into from
Jul 22, 2024

Commits on Jul 19, 2024

  1. cluster: Improve cluster restart messaging

    Cluster restart messaging indicates to user that the:
      - Cluster will be unavailable
        (https://github.com/pingcap/tiup/blob/654b087a1d293128424c0bd04e1ba216b064ffd1/pkg/cluster/manager/basic.go#L235)
    
    This message is confusing when the command run only requests a single
    node restart, especially monitoring nodes or ones in an HA deployment.
    
    Commit changes the messaging so that users performing full cluster
    restart retain the same message as before. But users only restarting
    selected nodes or roles will have that replaced with a more detailed warning message:
    
    `Cluster functionality related to nodes: %s and roles: % will be
    unavailable`
    zph committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    48ea8e4 View commit details
    Browse the repository at this point in the history