Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: support microservices mode #2226

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jul 10, 2023

What problem does this PR solve?

Introduce the pd-ms mode for better testing of the PD microservices mode.

Ref #2429

What is changed and how it works?

Usage:

tiup-playground nightly --pd.mode ms

It will start 1 API, 1 TSO, 1 resource manager server by default. If we want to start more, just use the following cmd like other mode:

tiup-playground nightly --pd.mode ms --pd.api 3 --pd.tso 2 --pd.rm 1

Output:

🎉 TiDB Playground Cluster is started, enjoy!

Connect TiDB:   mysql --comments --host 127.0.0.1 --port 4000 -u root
TiDB Dashboard: http://127.0.0.1:2379/dashboard
Grafana:        http://127.0.0.1:3000

For tikv-slim:

tiup-playground nightly --mode tikv-slim --pd.mode ms --pd.api 3 --pd.tso 2 --pd.rm 1

Output:

PD TSO Endpoints:   127.0.0.1:2386,127.0.0.1:2388
PD API Endpoints:   127.0.0.1:2379,127.0.0.1:2382,127.0.0.1:2384
PD Resource Ranager Endpoints:   127.0.0.1:2390
Grafana:        http://127.0.0.1:3000

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested review from breezewish and srstack July 10, 2023 08:31
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 10, 2023
@kaaaaaaang
Copy link
Collaborator

some arg name may confused, reset LGTM

Signed-off-by: Ryan Leung <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.82 🎉

Comparison is base (7b36b25) 50.53% compared to head (d7a80f3) 51.35%.

❗ Current head d7a80f3 differs from pull request most recent head 0979a55. Consider uploading reports for the commit 0979a55 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2226      +/-   ##
==========================================
+ Coverage   50.53%   51.35%   +0.82%     
==========================================
  Files         320      304      -16     
  Lines       33685    32982     -703     
==========================================
- Hits        17022    16937      -85     
+ Misses      14614    14007     -607     
+ Partials     2049     2038      -11     
Flag Coverage Δ
cluster 44.67% <0.00%> (+8.81%) ⬆️
dm 19.61% <0.00%> (-6.42%) ⬇️
playground ?
tiup 15.93% <0.00%> (-0.03%) ⬇️
unittest 22.64% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/command.go 0.00% <ø> (-79.59%) ⬇️
components/playground/main.go 2.02% <0.00%> (-56.79%) ⬇️
components/playground/playground.go 0.00% <0.00%> (-49.00%) ⬇️
pkg/tidbver/tidbver.go 86.44% <0.00%> (-6.54%) ⬇️

... and 112 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 13, 2023
Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 14, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-14 09:34:47.727388166 +0000 UTC m=+670179.497726880: ☑️ agreed by kaaaaaaang.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 14, 2023
@ti-chi-bot ti-chi-bot bot merged commit a7aa964 into pingcap:master Jul 14, 2023
16 checks passed
@rleungx rleungx deleted the ms branch July 14, 2023 09:39
@kaaaaaaang kaaaaaaang added this to the 1.13.0 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants