Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add ssh proxy testcases #1470

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

9547
Copy link
Contributor

@9547 9547 commented Jul 2, 2021

What problem does this PR solve?

Add more ssh-proxy-based test cases.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@9547 9547 marked this pull request as draft July 2, 2021 14:37
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2021
@ti-chi-bot ti-chi-bot requested review from lonng and lucklove July 2, 2021 14:37
@9547 9547 changed the title Feature/add ssh proxy testcases tests: add ssh proxy testcases Jul 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.76%. Comparing base (b38df71) to head (61b90f8).
Report is 408 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1470       +/-   ##
===========================================
+ Coverage   15.80%   50.76%   +34.95%     
===========================================
  Files         149      290      +141     
  Lines       15023    26349    +11326     
===========================================
+ Hits         2375    13376    +11001     
+ Misses      12131    10962     -1169     
- Partials      517     2011     +1494     
Flag Coverage Δ
cluster 43.86% <ø> (?)
dm 26.18% <ø> (?)
integrate 50.76% <ø> (+34.95%) ⬆️
playground 13.54% <ø> (?)
tiup 15.78% <ø> (-0.02%) ⬇️
unittest ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot
Copy link
Member

@9547: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ nexustar
❌ jsvisa
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants