cluster: fix tidb-dashboard listen_host (#2304)

pingcap · Nov 8, 2023 · 310afd1 · 310afd1
1 parent 2eaf957
commit 310afd1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/embed/templates/scripts/run_tidb-dashboard.sh.tpl b/embed/templates/scripts/run_tidb-dashboard.sh.tpl
@@ -13,7 +13,7 @@ exec numactl --cpunodebind={{.NumaNode}} --membind={{.NumaNode}} bin/tidb-dashbo
 exec bin/tidb-dashboard \
 {{- end}}
     --feature-version="{{.TidbVersion}}" \
-    --host="{{.IP}}" \
+    --host="{{.Host}}" \
     --port="{{.Port}}" \
     --pd="{{.PD}}" \
     --data-dir="{{.DataDir}}" \

diff --git a/pkg/cluster/spec/dashboard.go b/pkg/cluster/spec/dashboard.go
@@ -209,8 +209,9 @@ func (i *DashboardInstance) InitConfig(
 		pds = append(pds, pdspec.GetAdvertiseClientURL(enableTLS))
 	}
 	cfg := &scripts.DashboardScript{
+		// -h, --host string              listen host of the Dashboard Server
+		Host:        i.GetListenHost(),
 		TidbVersion: clusterVersion,
-		IP:          i.GetHost(),
 		DeployDir:   paths.Deploy,
 		DataDir:     paths.Data[0],
 		LogDir:      paths.Log,

diff --git a/pkg/cluster/template/scripts/dashboard.go b/pkg/cluster/template/scripts/dashboard.go
@@ -25,7 +25,7 @@ import (
 // DashboardScript represent the data to generate cdc config
 type DashboardScript struct {
 	TidbVersion string
-	IP          string
+	Host        string
 	Port        int
 	DeployDir   string
 	LogDir      string