Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cp-2790] Fix gc max wait time #2792

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

shiyuhang0
Copy link
Member

@shiyuhang0 shiyuhang0 commented Sep 2, 2024

What problem does this PR solve?

cp #2790

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot bot added the size/S label Sep 2, 2024
@shiyuhang0 shiyuhang0 changed the title cp [cp-2791] Fix gc max wait time Sep 2, 2024
@zhexuany
Copy link
Contributor

@shiyuhang0 If this is a cherry-pick commit, maybe better attribute the original PR in this cherry-pick PR.

@shiyuhang0 shiyuhang0 changed the title [cp-2791] Fix gc max wait time [cp-2790] Fix gc max wait time Sep 27, 2024
@shiyuhang0
Copy link
Member Author

@shiyuhang0 If this is a cherry-pick commit, maybe better attribute the original PR in this cherry-pick PR.

sure, will do it

@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

1 similar comment
@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

Copy link

ti-chi-bot bot commented Oct 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-08 13:54:43.445022262 +0000 UTC m=+967838.865235266: ☑️ agreed by zhangyangyu.

Copy link

ti-chi-bot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhangyangyu
Once this PR has been reviewed and has the lgtm label, please ask for approval from shiyuhang0, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shiyuhang0 shiyuhang0 merged commit 8f7901e into pingcap:release-3.1 Oct 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants