Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): fix incorrect encoding default value in Avro protocol #11995

Merged
merged 3 commits into from
Jan 15, 2025
Merged

sink(ticdc): fix incorrect encoding default value in Avro protocol #11995

merged 3 commits into from
Jan 15, 2025
+24 −1

Conversation

wk989898
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #11994

What is changed and how it works?

treat as a nil when the default value is the string literal "null"

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

 Fix incorrect encoding default value in Avro protocol.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 11, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 13, 2025
@wk989898
Copy link
Collaborator Author

/retest

@wk989898
Copy link
Collaborator Author

/check-issue-triage-complete

@wk989898
Copy link
Collaborator Author

/retest

@wk989898
Copy link
Collaborator Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 15, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-13 03:19:03.492530873 +0000 UTC m=+755686.781362578: ☑️ agreed by 3AceShowHand.
  • 2025-01-15 10:36:20.118146898 +0000 UTC m=+114851.573193048: ☑️ agreed by asddongmen.

@ti-chi-bot ti-chi-bot bot merged commit fbd02e7 into pingcap:master Jan 15, 2025
26 checks passed
@wk989898 wk989898 added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jan 15, 2025
@wk989898
Copy link
Collaborator Author

/run-cherry-picker

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 15, 2025
@wk989898 @ti-chi-bot
This is an automated cherry-pick of pingcap#11995
30aa5c6 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 15, 2025
@wk989898 @ti-chi-bot
This is an automated cherry-pick of pingcap#11995
5fd9a26 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #12005.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #12006.

This was referenced Jan 15, 2025
Open
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12007.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 15, 2025
@wk989898 @ti-chi-bot
This is an automated cherry-pick of pingcap#11995
dd4d9a0 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 15, 2025
@wk989898 @ti-chi-bot
This is an automated cherry-pick of pingcap#11995
eb107d1 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 15, 2025
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #12008.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #12009.

This was referenced Jan 15, 2025
Merged
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #12010.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 15, 2025
@wk989898 @ti-chi-bot
This is an automated cherry-pick of pingcap#11995
902cce5 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 15, 2025
Open
ti-chi-bot bot pushed a commit that referenced this pull request Jan 16, 2025
@ti-chi-bot
sink(ticdc): fix incorrect encoding default value in Avro protocol (#…
b80fd10 
…11995) (#12008)

close #11994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

encoding default "null" failed in avro protocol
4 participants
@wk989898 @ti-chi-bot @3AceShowHand @asddongmen