Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: build sync_diff_inspector from source code to run tests #11988

Merged
merged 14 commits into from
Jan 16, 2025
Merged

*: build sync_diff_inspector from source code to run tests #11988

merged 14 commits into from
Jan 16, 2025

Conversation

joechenrh
Copy link
Contributor

@joechenrh joechenrh commented Jan 8, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #11672

What is changed and how it works?

Use sync_diff_inspector built from source to run all tests.

There are 7 CI related to this PR:

  • pull_cdc_integration_kafka_test
  • pull_cdc_integration_pulsar_test
  • pull_cdc_integration_storage_test
  • pull_cdc_integration_test
  • pull_dm_compatibility_test
  • pull_engine_integration_test
  • pull_dm_integration_test

The original logic of these CI can be summarized as:

download binarys --> check versions of each binary --> build tools from source --> run test

Changes of the first five CI is simple, just remove the version check of sync_diff_inspector since we will build sync_diff_inspector from source in the third step, see PingCAP-QE/ci#3315. You can check the result of these CI in this PR.

And changes of the last two CI will be merged in PingCAP-QE/ci#3316. @purelind has helped me to rerun these two test using this PR and modified CI. Below are the records of successful test:

This PR will be merged with the CI changes by @purelind during free time.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/dm Issues or PRs related to DM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2025
@joechenrh
Copy link
Contributor Author

/hold
Will be merged together with the CI modification in idle time

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@joechenrh
Copy link
Contributor Author

/retest

@joechenrh joechenrh mentioned this pull request Jan 10, 2025
Merged
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 13, 2025
ti-chi-bot bot pushed a commit to PingCAP-QE/ci that referenced this pull request Jan 14, 2025
@joechenrh
Remove sync_diff_inspector version check from tiflow CI (#3315)
ea3ee43 
Corresponding tiflow PR: pingcap/tiflow#11988

This is the first step of CI changes. The change of
pull_dm_integration_test and pull_engine_integration_test will be added
in another PR.
@purelind
Copy link
Collaborator

/retest

@joechenrh
Copy link
Contributor Author

/retest

D3Hunter
D3Hunter reviewed Jan 15, 2025
View reviewed changes
sync_diff_inspector/source/chunks_iter.go
return iter, nil
}

func (t *ChunksIterator) produceChunks(startRange *splitter.RangeInfo) {
defer func() {
t.pool.WaitFinished()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we return early on error, will it leak anything without wait?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the change here (t.pool.WaitFinished()) was added when I migrate the code in the last PR.
Here I just revert the change again...

sync_diff_inspector/utils/table.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 15, 2025
GMHDBJD
GMHDBJD approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 15, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-15 06:21:13.894353052 +0000 UTC m=+99545.349399198: ☑️ agreed by D3Hunter.
  • 2025-01-15 08:58:56.940599611 +0000 UTC m=+109008.395645754: ☑️ agreed by GMHDBJD.

@joechenrh
Copy link
Contributor Author

/retest

@purelind
Copy link
Collaborator

/retest

@purelind
Copy link
Collaborator

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2025
@purelind
Copy link
Collaborator

/retest

1 similar comment
@purelind
Copy link
Collaborator

/retest

@ti-chi-bot ti-chi-bot bot merged commit f2eaa2c into pingcap:master Jan 16, 2025
26 checks passed
@joechenrh joechenrh deleted the change-build branch January 17, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees
No one assigned
Labels
approved area/dm Issues or PRs related to DM. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move diff package from tidb-tools to tiflow repo
4 participants
@joechenrh @purelind @D3Hunter @GMHDBJD