Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): fix incorrect sanitize #11728

Closed
wants to merge 2 commits into from
Closed

Conversation

wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Nov 7, 2024

What problem does this PR solve?

Issue Number: close #11727

What is changed and how it works?

PingCAP-QE/ci#3208 cause this issue, and we have to revert #11649.
After this pr,an invalid character is replaced by a replacementChar.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 7, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 7, 2024
@3AceShowHand
Copy link
Contributor

/check-issue-triage-complete

Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-07 06:25:28.249049615 +0000 UTC m=+1108641.088205154: ☑️ agreed by 3AceShowHand.
  • 2024-11-07 06:39:42.969650226 +0000 UTC m=+1109495.808805765: ☑️ agreed by CharlesCheung96.

@wk989898
Copy link
Collaborator Author

wk989898 commented Nov 7, 2024

/retest

@wk989898
Copy link
Collaborator Author

wk989898 commented Nov 7, 2024

/retest

Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2024

@wk989898: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-kafka-test 7ac2176 link true /test cdc-integration-kafka-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.1839%. Comparing base (1da37a2) to head (7ac2176).
Report is 1 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.6412% <0.0000%> (+0.0083%) ⬆️
dm 50.1097% <ø> (+0.0654%) ⬆️
engine 53.2505% <ø> (+0.0225%) ⬆️
Flag Coverage Δ
unit 55.1839% <0.0000%> (+0.0317%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11728        +/-   ##
================================================
+ Coverage   55.1522%   55.1839%   +0.0317%     
================================================
  Files          1001       1001                
  Lines        136524     136518         -6     
================================================
+ Hits          75296      75336        +40     
+ Misses        55718      55681        -37     
+ Partials       5510       5501         -9     

@wk989898
Copy link
Collaborator Author

wk989898 commented Feb 5, 2025

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

@wk989898: cannot cherry-pick an unmerged PR.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect sanitize name
4 participants