Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): remove duplicate sort about open protocol #11601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wk989898
Copy link
Contributor

@wk989898 wk989898 commented Sep 14, 2024

What problem does this PR solve?

Issue Number: ref #10913

What is changed and how it works?

Repeat with the following code

sort.Slice(sinkCols, func(i, j int) bool {
return strings.Compare(sinkCols[i].Name, sinkCols[j].Name) > 0
})

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from wk989898, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-triage-completed labels Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.4835%. Comparing base (45c831a) to head (e94694f).

Additional details and impacted files
Components Coverage Δ
cdc 61.2521% <ø> (+0.0200%) ⬆️
dm 51.0213% <ø> (-0.0122%) ⬇️
engine 63.4091% <ø> (+0.0141%) ⬆️
Flag Coverage Δ
unit 57.4835% <ø> (+0.0063%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11601        +/-   ##
================================================
+ Coverage   57.4771%   57.4835%   +0.0063%     
================================================
  Files           851        851                
  Lines        126539     126525        -14     
================================================
  Hits          72731      72731                
+ Misses        48407      48396        -11     
+ Partials       5401       5398         -3     

@wk989898
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant