Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update OWNERS_ALIASES #11495

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Aug 20, 2024

update member of alias group sig-critical-approvers-cdc: kevin-xianliu retired

Signed-off-by: wuhuizuo [email protected]

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

update member of alias group sig-critical-approvers-cdc

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2024
@wuhuizuo
Copy link
Contributor Author

/label skip-issue

Copy link
Contributor

ti-chi-bot bot commented Aug 20, 2024

@wuhuizuo: The label(s) skip-issue cannot be applied. These labels are supported: duplicate, bug-from-internal-test, bug-from-user, ok-to-test, needs-ok-to-test, affects-5.4, affects-6.1, affects-6.5, affects-7.1, affects-7.5, affects-8.1, affects-8.3, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1, may-affects-7.5, may-affects-8.1, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-cherry-pick-release-8.1, needs-cherry-pick-release-8.3, question, release-blocker, wontfix, MariaDB.

In response to this:

/label skip-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the skip-issue-check Indicates that a PR no need to check linked issue. label Aug 20, 2024
@wuhuizuo
Copy link
Contributor Author

Copy link
Contributor

ti-chi-bot bot commented Aug 20, 2024

@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: yudongusa, BenMeadowcroft.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yudongusa @benmeadowcroft @flowbehappy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested a review from flowbehappy August 20, 2024 02:17
@wuhuizuo
Copy link
Contributor Author

/cherry-pick release-8.3
/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

@ti-chi-bot
Copy link
Member

@wuhuizuo: once the present PR merges, I will cherry-pick it on top of release-6.1/release-6.5/release-7.1/release-7.5/release-8.1/release-8.3 in the new PR and assign it to you.

In response to this:

/cherry-pick release-8.3
/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@@ -1,7 +1,7 @@
# Sort the member alphabetically.
aliases:
sig-critical-approvers-cdc:
- kevin-xianliu
- yudongusa
Copy link
Contributor Author

@wuhuizuo wuhuizuo Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yudongusa

PTAL, if we need to add more members, please review with suggestion code.

Copy link
Contributor

ti-chi-bot bot commented Aug 20, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 20, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-20 03:18:51.658463508 +0000 UTC m=+235526.792913623: ☑️ agreed by sdojjy.
  • 2024-08-20 03:19:31.869288163 +0000 UTC m=+235567.003738319: ☑️ agreed by CharlesCheung96.

Copy link
Contributor

ti-chi-bot bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, CharlesCheung96, flowbehappy, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot merged commit 3c1e436 into pingcap:master Aug 20, 2024
9 of 10 checks passed
@wuhuizuo wuhuizuo deleted the ci/update-owners branch August 20, 2024 03:32
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-8.3: #11496.

In response to this:

/cherry-pick release-8.3
/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wuhuizuo
Copy link
Contributor Author

/cherry-pick release-8.3

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Aug 20, 2024
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-8.1: #11497.

In response to this:

/cherry-pick release-8.3
/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request could not be created: failed to create pull request against pingcap/tiflow#release-8.3 from head ti-chi-bot:cherry-pick-11495-to-release-8.3: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-11495-to-release-8.3."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-8.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-7.5: #11498.

In response to this:

/cherry-pick release-8.3
/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Aug 20, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Aug 20, 2024
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-7.1: #11499.

In response to this:

/cherry-pick release-8.3
/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-6.5: #11500.

In response to this:

/cherry-pick release-8.3
/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Aug 20, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Aug 20, 2024
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-6.1: #11501.

In response to this:

/cherry-pick release-8.3
/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants