-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backup/pitr_coll: use target client of S3 #59044
Conversation
Signed-off-by: hillium <[email protected]>
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -110,9 +110,8 @@ func (rs *S3Storage) CopyFrom(ctx context.Context, e ExternalStorage, spec CopyS | |||
Key: aws.String(rs.options.Prefix + spec.To), | |||
} | |||
|
|||
// NOTE: Maybe check whether the Go SDK will handle 200 OK errors. | |||
// https://repost.aws/knowledge-center/s3-resolve-200-internalerror |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed because I have checked the document and it reads:
If you call this API operation directly, make sure to design your application to parse the content of the response and handle it appropriately. If you use AWS SDKs, SDKs handle this condition. The SDKs detect the embedded error and apply error handling per your configuration settings (including automatically retrying the request as appropriate). If the condition persists, the SDKs throw an exception (or, for the SDKs that don't use exceptions, they return an error).
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, RidRisR The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/hold before testing done |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59044 +/- ##
================================================
+ Coverage 73.0189% 74.8666% +1.8476%
================================================
Files 1683 1729 +46
Lines 465735 473872 +8137
================================================
+ Hits 340075 354772 +14697
+ Misses 104710 96686 -8024
- Partials 20950 22414 +1464
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/unhold |
What problem does this PR solve?
Issue Number: close #59043
Problem Summary:
We used the wrong client to copy object.
What changed and how does it work?
Used the rightly configured client to copy object.
Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
With the new client, now it returns no more
BucketRegionError
.No need to test
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.