-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, indexusage: don't load stats for point get index usage reporter #58478
base: master
Are you sure you want to change the base?
Conversation
TODO: performance test |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #58478 +/- ##
================================================
+ Coverage 73.1476% 73.5549% +0.4072%
================================================
Files 1678 1678
Lines 464086 464188 +102
================================================
+ Hits 339468 341433 +1965
+ Misses 103772 101917 -1855
+ Partials 20846 20838 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f712b3f
to
14485c4
Compare
The automatic test doesn't give a good result 🤔 . Maybe the improvement is not that significant (or the benchmark platform may have too big variation).
Theoretically, this PR should never hurt performance. I'll try to do the benchmark manually to make sure there is nothing wrong 🤔 . |
1644084
to
5eaa2e6
Compare
Signed-off-by: Yang Keao <[email protected]>
5eaa2e6
to
d3e7296
Compare
What problem does this PR solve?
Issue Number: close #58477
Problem Summary:
As described in the issue, maybe load stats is too slow for point get requests.
What changed and how does it work?
Check List
Tests
It has been covered by existing tests.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.