planner: merge FullSchema and FullNames of subplans when rewriting "in (subquery)" to inner join (#54334)

[ti-chi-bot]

This is an automated cherry-pick of #54334

What problem does this PR solve?

Issue Number: close #53766

Problem Summary:

What changed and how does it work?

Merge FullSchema and FullNames of subplans when rewring "in (subquery)" to inner join, which will be used to rewrite fields when using natural join.

tidb/pkg/planner/core/expression_rewriter.go

Lines 2469 to 2485 in 4381699

	func findFieldNameFromNaturalUsingJoin(p base.LogicalPlan, v *ast.ColumnName) (col *expression.Column, name *types.FieldName, err error) {
	switch x := p.(type) {
	case *LogicalLimit, *LogicalSelection, *LogicalTopN, *LogicalSort, *LogicalMaxOneRow:
	return findFieldNameFromNaturalUsingJoin(p.Children()[0], v)
	case *LogicalJoin:
	if x.FullSchema != nil {
	idx, err := expression.FindFieldName(x.FullNames, v)
	if err != nil {
	return nil, nil, err
	}
	if idx >= 0 {
	return x.FullSchema.Columns[idx], x.FullNames[idx], nil
	}
	}
	}
	return nil, nil, nil
	}

The merging code I referenced was from the code in buildJoin as follows:

tidb/pkg/planner/core/logical_plan_builder.go

Lines 985 to 1026 in 4381699

	// Merge sub-plan's FullSchema into this join plan.
	// Please read the comment of LogicalJoin.FullSchema for the details.
	var (
	lFullSchema, rFullSchema *expression.Schema
	lFullNames, rFullNames types.NameSlice
	)
	if left, ok := leftPlan.(*LogicalJoin); ok && left.FullSchema != nil {
	lFullSchema = left.FullSchema
	lFullNames = left.FullNames
	} else {
	lFullSchema = leftPlan.Schema()
	lFullNames = leftPlan.OutputNames()
	}
	if right, ok := rightPlan.(*LogicalJoin); ok && right.FullSchema != nil {
	rFullSchema = right.FullSchema
	rFullNames = right.FullNames
	} else {
	rFullSchema = rightPlan.Schema()
	rFullNames = rightPlan.OutputNames()
	}
	if joinNode.Tp == ast.RightJoin {
	// Make sure lFullSchema means outer full schema and rFullSchema means inner full schema.
	lFullSchema, rFullSchema = rFullSchema, lFullSchema
	lFullNames, rFullNames = rFullNames, lFullNames
	}
	joinPlan.FullSchema = expression.MergeSchema(lFullSchema, rFullSchema)
	// Clear NotNull flag for the inner side schema if it's an outer join.
	if joinNode.Tp == ast.LeftJoin || joinNode.Tp == ast.RightJoin {
	resetNotNullFlag(joinPlan.FullSchema, lFullSchema.Len(), joinPlan.FullSchema.Len())
	}
	// Merge sub-plan's FullNames into this join plan, similar to the FullSchema logic above.
	joinPlan.FullNames = make([]*types.FieldName, 0, len(lFullNames)+len(rFullNames))
	for _, lName := range lFullNames {
	name := *lName
	joinPlan.FullNames = append(joinPlan.FullNames, &name)
	}
	for _, rName := range rFullNames {
	name := *rName
	joinPlan.FullNames = append(joinPlan.FullNames, &name)
	}

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-10-31 09:29:38.622916233 +0000 UTC m=+514891.462071779: ☑️ agreed by AilinKid.
• 2024-10-31 09:30:50.780891079 +0000 UTC m=+514963.620046623: ☑️ agreed by hawkingrei.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.1@c0288ad). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-7.1     #57036   +/-   ##
================================================
  Coverage               ?   73.5647%           
================================================
  Files                  ?       1211           
  Lines                  ?     381177           
  Branches               ?          0           
================================================
  Hits                   ?     280412           
  Misses                 ?      82971           
  Partials               ?      17794           

[AilinKid]

/test unit-test

[tiprow]

@AilinKid: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.