Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: ks3 domain mode #53790

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

br: ks3 domain mode #53790

wants to merge 6 commits into from

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Jun 4, 2024

What problem does this PR solve?

Issue Number: close #53775

Problem Summary:
introduce domain mode for ks3 sdk

What changed and how does it work?

for ks3 server,

  1. path//file and path/file are different places.
  2. return http status code 404 if file does not exist.
  3. use ks3 sdk in default if the endpoint contains ksyuncs.com.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Leavrth added 2 commits June 4, 2024 11:06
Signed-off-by: Jianjun Liao <[email protected]>
Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2024
Copy link

tiprow bot commented Jun 4, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 74.4216%. Comparing base (5ed9e63) to head (07a5752).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53790        +/-   ##
================================================
+ Coverage   73.0395%   74.4216%   +1.3820%     
================================================
  Files          1684       1730        +46     
  Lines        465705     473818      +8113     
================================================
+ Hits         340149     352623     +12474     
+ Misses       104636      98795      -5841     
- Partials      20920      22400      +1480     
Flag Coverage Δ
integration 46.7987% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.0143% <0.0000%> (+15.7046%) ⬆️

Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

br/pkg/storage/parse_test.go Show resolved Hide resolved
Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2024
@lance6716
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 4, 2024
Copy link

ti-chi-bot bot commented Jun 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-04 10:06:49.5910604 +0000 UTC m=+3375763.348195968: ☑️ agreed by lance6716.

Leavrth added 2 commits June 4, 2024 18:07
Signed-off-by: Jianjun Liao <[email protected]>
Copy link

ti-chi-bot bot commented Jun 4, 2024

@lance6716: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 20, 2025
Copy link

ti-chi-bot bot commented Jan 20, 2025

@Leavrth: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 07a5752 link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 07a5752 link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

introduce the domainmode for ks3 sdk
2 participants