ddl: Reorganize partition supporting global index

[mjonss]

What problem does this PR solve?

Issue Number: ref #45133
REORGANIZE PARTITION is not allowed for tables with GLOBAL INDEX

Problem Summary:
This was disabled, since Global index was not stable. Now when we are stabilizing Global index, this is a functionality blocker.

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 85.50725% with 30 lines in your changes missing coverage. Please review.

Project coverage is 55.6279%. Comparing base (87999d1) to head (f4ee2d3).
Report is 39 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #53277         +/-   ##
=================================================
- Coverage   74.4295%   55.6279%   -18.8017%     
=================================================
  Files          1506       1626        +120     
  Lines        357522     609915     +252393     
=================================================
+ Hits         266102     339283      +73181     
- Misses        71987     247667     +175680     
- Partials      19433      22965       +3532     

Flag	Coverage Δ
integration	36.3188% <81.6425%> (?)
unit	71.4407% <82.6087%> (-1.8615%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (-3.3316%)	⬇️
parser	∅ <ø> (∅)
br	50.3682% <ø> (+6.8361%)	⬆️

[hawkingrei]

/ok-to-test

[mjonss]

/retest

[AilinKid]

great work, it seems most of this pull request is related to the DDL module, I'm not quite familiar with this part. @zimulala @tangenta

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-05-22 05:36:12.752758477 +0000 UTC m=+2236326.509894051: ☑️ agreed by Defined2014.
• 2024-06-01 15:01:29.416205018 +0000 UTC m=+3134243.173340591: ☑️ agreed by jiyfhust.

[tangenta]

7/11, will review later

[tangenta]

It seems there is a chance to have two "primary keys", I am not sure if there are problems

CREATE TABLE `t3` (
  `a` int(11) NOT NULL,
  `b` int(11) DEFAULT NULL,
  PRIMARY KEY (`a`) /*T![clustered_index] NONCLUSTERED */,
  UNIQUE KEY `idx_b` (`b`),
  UNIQUE KEY `idx_a` (`a`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin
PARTITION BY HASH (`a`) PARTITIONS 3

alter table t3 partition by hash(b) partitions 3;

[tangenta]

Maybe we can add DML tests during reorganizing partitions in next PR.

[mjonss]

There should only be one 'PRIMARY KEY' (due to definition of what a primary key is) but multiple candidate keys are possible (i.e. unique indexes of not null columns), both using global index as well as non-partitioned tables.
Also I don't think there are any limitations for having duplicate indexes with different names, are there?

[tangenta]

Also I don't think there are any limitations for having duplicate indexes with different names, are there?

+1

I mean there are multiple indexes with index.Primary == true during reorg partitions, it breaks the assumption of "there is only one primary index at anytime". But I can't figure out any scenarios that can cause errors for now

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, jiyfhust, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Defined2014,jiyfhust,tangenta]
• pkg/ddl/OWNERS [tangenta]
• pkg/table/OWNERS [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #54562.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #55051.