Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor, indexusage: don't load stats for point get index usage reporter #58478

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

executor, indexusage: don't load stats for point get index usage reporter #58478

wants to merge 1 commit into from
+31 −18

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Dec 23, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58477

Problem Summary:

As described in the issue, maybe load stats is too slow for point get requests.

What changed and how does it work?

  1. Don't load stats for point get requests.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

It has been covered by existing tests.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 23, 2024
@YangKeao
Copy link
Member Author

TODO: performance test

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from yangkeao, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 23, 2024
@YangKeao YangKeao marked this pull request as draft December 23, 2024 09:13
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 45.45455% with 12 lines in your changes missing coverage. Please review.

Project coverage is 73.5662%. Comparing base (ef7ade7) to head (f712b3f).
Report is 2 commits behind head on master.

❗ Current head f712b3f differs from pull request most recent head 14485c4

Please upload reports for the commit 14485c4 to get more accurate results.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58478        +/-   ##
================================================
+ Coverage   73.5359%   73.5662%   +0.0303%     
================================================
  Files          1681       1681                
  Lines        464055     464671       +616     
================================================
+ Hits         341247     341841       +594     
- Misses       101997     102033        +36     
+ Partials      20811      20797        -14
Flag Coverage Δ
integration 43.1804% <45.4545%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7756% <ø> (+0.0089%) ⬆️

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 23, 2024

@YangKeao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test f712b3f link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@YangKeao YangKeao force-pushed the not-load-stats-for-point-get branch from f712b3f to 14485c4 Compare December 23, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't load stats in index usage reporter for point get requests to accelerate it
1 participant
@YangKeao