Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tikvgroup): refactor to use task v3 and add more uts #6016

Open
wants to merge 1 commit into
base: feature/v2
Choose a base branch
from

Conversation

liubog2008
Copy link
Member

  • change tikvgroup to use task v3
  • add uts for tikvgroup
  • extract finalizer add task to common

Copy link
Contributor

ti-chi-bot bot commented Dec 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL label Dec 27, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 59.25110% with 185 lines in your changes missing coverage. Please review.

Project coverage is 35.07%. Comparing base (90a3a2a) to head (fefdd24).

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v2    #6016      +/-   ##
==============================================
+ Coverage       31.91%   35.07%   +3.16%     
==============================================
  Files             153      154       +1     
  Lines            9945    10077     +132     
==============================================
+ Hits             3174     3535     +361     
+ Misses           6517     6283     -234     
- Partials          254      259       +5     
Flag Coverage Δ
unittest 35.07% <59.25%> (+3.16%) ⬆️

@liubog2008 liubog2008 added the v2 for operator v2 label Dec 27, 2024
@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-v2

1 similar comment
@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL v2 for operator v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants