Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): add ut for common tasks and refactor task utils #6010

Merged
merged 4 commits into from
Dec 25, 2024

Conversation

liubog2008
Copy link
Member

  • Add ut for common task
  • Add ctx into task v3
  • Rename ctx to state in pd tasks
  • Add State interface in pd tasks

@ti-chi-bot ti-chi-bot bot added the size/XXL label Dec 24, 2024
Signed-off-by: liubo02 <[email protected]>
Signed-off-by: liubo02 <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 45.58824% with 148 lines in your changes missing coverage. Please review.

Project coverage is 24.50%. Comparing base (a716b34) to head (96e1ff7).

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v2    #6010      +/-   ##
==============================================
+ Coverage       23.29%   24.50%   +1.21%     
==============================================
  Files             149      151       +2     
  Lines            9862     9912      +50     
==============================================
+ Hits             2297     2429     +132     
+ Misses           7377     7294      -83     
- Partials          188      189       +1     
Flag Coverage Δ
unittest 24.50% <45.58%> (+1.21%) ⬆️

Copy link
Contributor

ti-chi-bot bot commented Dec 25, 2024

@csuzhangxc: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit 749fbbb into pingcap:feature/v2 Dec 25, 2024
6 of 7 checks passed
@liubog2008 liubog2008 added the v2 for operator v2 label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL v2 for operator v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants