Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: mark volume backup complete only when all data planes are at waiting snapshots creation time #5733

Closed

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Sep 4, 2024

What problem does this PR solve?

closes #5725

What is changed and how does it work?

only set volume backup is done (failed or complete) after all data planes are done at waiting snapshot creation time whose during is long.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


…ing waiting snapshots creation time

Signed-off-by: BornChanger <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bornchanger, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L label Sep 4, 2024
@BornChanger BornChanger changed the title ebs br: mark volume backup complete only when all data planes are dur… ebs br: mark volume backup complete only when all data planes are at waiting snapshots creation time Sep 4, 2024
@BornChanger BornChanger requested review from WangLe1321 and csuzhangxc and removed request for howardlau1999 September 4, 2024 13:14
@BornChanger
Copy link
Contributor Author

dup with apar #5735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebs br: don't mark volumebackup failed too early
1 participant