-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLA Required] Update variables.tf #4162
base: master
Are you sure you want to change the base?
Conversation
upgrade ack cluster version from 1.14.8-aliyun.1 to 1.18.8-aliyun.1
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
add k8s cluster spec
add default value for k8s cluster spec -- ack pro
@lilongthinker Please sign the CLA, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #4162 +/- ##
=======================================
Coverage 61.28% 61.29%
=======================================
Files 178 178
Lines 18986 18986
=======================================
+ Hits 11636 11637 +1
+ Misses 6206 6205 -1
Partials 1144 1144
|
@lilongthinker Could you please sign the CLA? Thanks! |
upgrade ack cluster version from 1.14.8-aliyun.1 to 1.18.8-aliyun.1
1.14.8-aliyun.1 is unsupported
What problem does this PR solve?
What is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.