Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLA Required] Update variables.tf #4162

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lilongthinker
Copy link

upgrade ack cluster version from 1.14.8-aliyun.1 to 1.18.8-aliyun.1

1.14.8-aliyun.1 is unsupported

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


upgrade ack cluster version from 1.14.8-aliyun.1 to 1.18.8-aliyun.1
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 28, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD
  • KanShiori

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ DanielZhangQD
❌ lilongthinker
You have signed the CLA already but the status is still pending? Let us recheck it.

add k8s cluster spec
add default value for k8s cluster spec -- ack pro
@DanielZhangQD
Copy link
Contributor

@lilongthinker Please sign the CLA, thanks!

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #4162 (f8ba660) into master (e865837) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4162   +/-   ##
=======================================
  Coverage   61.28%   61.29%           
=======================================
  Files         178      178           
  Lines       18986    18986           
=======================================
+ Hits        11636    11637    +1     
+ Misses       6206     6205    -1     
  Partials     1144     1144           
Flag Coverage Δ
unittest 61.29% <ø> (+<0.01%) ⬆️

@DanielZhangQD
Copy link
Contributor

@lilongthinker Could you please sign the CLA? Thanks!

@DanielZhangQD DanielZhangQD changed the title Update variables.tf [CLA Required] Update variables.tf Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants