Handle MsgSnapshot sent before MsgAppend #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
JaySon-Huang
approved these changes
Aug 13, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Comment on lines
+102
to
+104
| info!("fast path: ongoing {}:{} {}, MsgSnapshot rejected", | ||
| self.store_id, region_id, new_peer_id; | ||
| "to_peer_id" => msg.get_to_peer().get_id(), |
There was a problem hiding this comment.
nit: format
Suggested change
| info!("fast path: ongoing {}:{} {}, MsgSnapshot rejected", | |
| self.store_id, region_id, new_peer_id; | |
| "to_peer_id" => msg.get_to_peer().get_id(), | |
| info!("fast path: ongoing {}:{} {}, MsgSnapshot rejected", | |
| self.store_id, region_id, new_peer_id; | |
| "to_peer_id" => msg.get_to_peer().get_id(), |
Signed-off-by: Calvin Neo <[email protected]>
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: Close #xxx
According to https://github.com/tikv/raft-rs/blob/2aefbf627f243dd261b7585ef1250d32efd9dfe7/src/raft.rs#L842,
if log is truncated in Leader, a MsgSnapshot may be sent directly before a MsgAppend.
If such MsgSnapshot is received when a FAP snapshot IS BUILDING, then it will be dropped.
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note