-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add QPS in tidb_dashboard ref:#1209 #1252
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: qidi1 <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
This is very cool! Will you also propose the CPU dimension in this PR, or in later PRs? |
Codecov Report
@@ Coverage Diff @@
## master #1252 +/- ##
==========================================
+ Coverage 31.53% 31.87% +0.34%
==========================================
Files 290 297 +7
Lines 17097 17118 +21
Branches 683 680 -3
==========================================
+ Hits 5391 5456 +65
+ Misses 11475 11431 -44
Partials 231 231
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@qidi1: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: qidi1 [email protected]
What problem does this PR solve?
Currently,Keyviz has
keys
andbytes
dimensions. In some situations, it cannot find the hotspot that the CPU is high caused by QPS, thekeys
andbytes
may be 0. For example:Issue Number: #1209
What is changed and how does it work?
Return QPS data in PD.
Check List
Tests
Related changes
Release note
Manual test
We ran a small cluster locally. On the cluster, test data was generated using the tiup bench tool. The results are shown in the figure below.