Drainer support plugin framework #911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @tsthght |
Closed
drainer/loopbacksync/loopbacksync.go
Outdated
| func CreateMarkTable(db *sql.DB, mdbname, mtablename string) error { | ||
| // CreateMarkDBDDL is DDL to create the database of mark table. | ||
| var err error | ||
| var CreateMarkDBDDL = fmt.Sprintf("create database IF NOT EXISTS %s;", mdbname) |
There was a problem hiding this comment.
how about use createMarkDBDDL because it is a variable in function now?
|
LGTM |
|
@july2993 PTAL |
|
@tsthght: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Drainer support plugin, #886
What is changed and how it works?
Add plugin framework to drainer, user can customize plugins, and use parameter
plugin-name,plugin-pathandsupport-pluginto load plugin into drainer.Check List
Tests