Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding line number and connect string to log.Fatalf for addConnection #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mjonss
Copy link
Collaborator

@mjonss mjonss commented Jan 14, 2022

When there is an issue with --connect command it will only fail saying it could not connect, but not show where in the test it failed.

This adds line number and connection arguments to the log.

dveeden
dveeden previously approved these changes Nov 8, 2022
Copy link
Collaborator

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on looking at the code

@dveeden
Copy link
Collaborator

dveeden commented Nov 8, 2022

@mjonss could you fix the conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants