Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_manager: add a new runaway action SwitchGroup #1254

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

JmPotato
Copy link
Member

Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

Copy link

ti-chi-bot bot commented Sep 2, 2024

@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nolouch
Copy link
Member

nolouch commented Sep 3, 2024

ptal @overvenus

@JmPotato
Copy link
Member Author

JmPotato commented Sep 4, 2024

/approve

@JmPotato
Copy link
Member Author

JmPotato commented Sep 4, 2024

/lgtm

Copy link

ti-chi-bot bot commented Sep 4, 2024

@JmPotato: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp
Copy link
Contributor

HuSharp commented Sep 4, 2024

/lgtm

Copy link

ti-chi-bot bot commented Sep 4, 2024

@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@overvenus
Copy link
Member

/lgtm

Copy link

ti-chi-bot bot commented Sep 4, 2024

@overvenus: Your lgtm message is repeated, so it is ignored.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, JmPotato, nolouch, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Sep 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-02 06:47:16.725190671 +0000 UTC m=+254161.243243596: ☑️ agreed by nolouch.
  • 2024-09-04 03:06:01.98128578 +0000 UTC m=+413686.499338705: ☑️ agreed by overvenus.
  • 2024-09-04 03:07:07.159496379 +0000 UTC m=+413751.677549303: ✖️🔁 reset by JmPotato.
  • 2024-09-04 03:11:44.024400518 +0000 UTC m=+414028.542453444: ☑️ agreed by overvenus.
  • 2024-09-04 03:13:48.114634255 +0000 UTC m=+414152.632687180: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit c2c652b into pingcap:master Sep 4, 2024
5 checks passed
@JmPotato JmPotato deleted the add_runaway_action branch September 4, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants