pdpb: Add err type and input param to BatchScanRegions #1252
Conversation
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
proto/pdpb.proto
Outdated
| @@ -377,6 +378,9 @@ message BatchScanRegionsRequest { | |||
|
|
|||
| repeated KeyRange ranges = 3; // the given ranges must be in order. | |||
| int32 limit = 4; // limit the total number of regions to scan. | |||
| // If output_must_contain_all_key_range is true, the output must contain all key ranges in the request. | |||
| // If the output does not contain all key ranges, the request is considered failed and returns an error(REGIONS_NOT_CONTAIN_ALL_KEY_RANGE). | |||
| bool output_must_contain_all_key_range = 5; | |||
There was a problem hiding this comment.
Do you have any better suggestions?😂
There was a problem hiding this comment.
What do you think which is better? @lance6716 @you06
There was a problem hiding this comment.
With the comment explaination, contain_all_key_range is clear enough to me.
Co-authored-by: Neil Shen <[email protected]>
Signed-off-by: okJiang <[email protected]>
…r-type Signed-off-by: okJiang <[email protected]>
|
If you have no question, could you please give me an approve? @you06 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rleungx, you06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We'd better merge such changes together with the related TiKV PRs to prevent breaking TiKV's build when using the master kvproto. |
got it |
ref tikv/pd#8358