Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft_serverpb: add an extra ExtraMessage::MsgAckCommittedIndex to get committed index. #1240

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Apr 11, 2024

Description

Ref: tikv/tikv#16800
Add an extra MsgAckCommittedIndex message to let peer have the ability of fetching the committed index from the leader.

…nse.

Supply the command pair `MsgAckCommittedRequest` and `MsgAckCommittedResponse` to check
the latest committed index of a specified peer.

Signed-off-by: lucasliang <[email protected]>
…sponse` with `AckCommittedIndex`

Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Copy link
Contributor Author

/cc @overvenus @glorv @SpadeA-Tang

proto/raft_serverpb.proto Outdated Show resolved Hide resolved
…and `AckCommittedIndexResponse`.

Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glorv glorv merged commit f87719b into pingcap:master Apr 11, 2024
4 checks passed
@LykxSassinator LykxSassinator deleted the ack_committed_idx branch April 12, 2024 03:05
LykxSassinator added a commit to LykxSassinator/kvproto that referenced this pull request Apr 17, 2024
…ex` to get committed index. (pingcap#1240)"

As the committed index can be fetched by the message pair `MsgReadIndex` and `MsgReadIndexResp`, it
can be reverted.

This reverts commit f87719b.
tonyxuqqi pushed a commit that referenced this pull request Apr 17, 2024
…ex` to get committed index. (#1240)" (#1243)

As the committed index can be fetched by the message pair `MsgReadIndex` and `MsgReadIndexResp`, it
can be reverted.

This reverts commit f87719b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants