Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add prow OWNERS file #1231

Merged
merged 15 commits into from
Apr 12, 2024
Merged

chore: add prow OWNERS file #1231

merged 15 commits into from
Apr 12, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Feb 29, 2024 •
edited
Loading

Ref: #1230

Why: we need control the changes of protobuf files strictly, the changes should approved by suitable teams.

@CLAassistant
Copy link

CLAassistant commented Feb 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@wuhuizuo wuhuizuo linked an issue Feb 29, 2024 that may be closed by this pull request
Setup OWNERS files to control the approving for protobuf files #1230
Closed
@wuhuizuo
Copy link
Contributor Author

@bb7133 will @tiancaiamao be a code owner for proto/autoid.proto? any others?

@BornChanger
Copy link
Contributor

proto/recoverdatapb.proto is also in BR domain. @wuhuizuo

@tonyxuqqi
Copy link
Contributor

raftstore related proto files:
proto/disk_usage.proto
proto/encryptionpb.proto
proto/metapb.proto
proto/raft_cmdpb.proto
proto/raft_serverpb.proto
proto/resource_manager.proto

@tonyxuqqi
Copy link
Contributor

@wuhuizuo Can multiple people be the owner of some files? If yes, please add @overvenus as owner as well for raftstore related proto files

@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Mar 8, 2024

@wuhuizuo Can multiple people be the owner of some files? If yes, please add @overvenus as owner as well for raftstore related proto files

Yes, I will update it.

@wuhuizuo wuhuizuo force-pushed the ci/add-owners-files branch 2 times, most recently from f7f5541 to 662db4b Compare March 8, 2024 03:42
@cfzjywxk
Copy link
Contributor

@wuhuizuo
I made some changes to the description updateing owner information, PTAL

@wuhuizuo
Copy link
Contributor Author

@tonyxuqqi could you help me to solve the failure of the rust-test CI task? It looks it deals all files include the OWNERS file.

@wuhuizuo wuhuizuo marked this pull request as ready for review April 1, 2024 11:22
wuhuizuo
wuhuizuo commented Apr 1, 2024
View reviewed changes
OWNERS Outdated Show resolved Hide resolved
@wuhuizuo
ci: fix build.rs
d9846b0 
ignore the no proto files
wuhuizuo
wuhuizuo commented Apr 1, 2024
View reviewed changes
scripts/check.sh Outdated Show resolved Hide resolved
@wuhuizuo
ci: fix check.sh
5037f18 
fast fail when install protolock failed.
@wuhuizuo wuhuizuo requested a review from lance6716 April 1, 2024 12:52
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Apr 2, 2024

/cc @bb7133 @tiancaiamao @BornChanger @flowbehappy @cfzjywxk @MyonKeminta @cfzjywxk @tonyxuqqi @overvenus @niubell @you06 @lance6716 @YuJuncen

PTAL

wuhuizuo
wuhuizuo commented Apr 8, 2024
View reviewed changes
proto/OWNERS Outdated Show resolved Hide resolved
wuhuizuo
wuhuizuo commented Apr 8, 2024
View reviewed changes
OWNERS_ALIASES Outdated Show resolved Hide resolved
wuhuizuo
wuhuizuo commented Apr 8, 2024
View reviewed changes
proto/OWNERS Outdated Show resolved Hide resolved
overvenus
overvenus reviewed Apr 9, 2024
View reviewed changes
build.rs Show resolved Hide resolved
@overvenus
Copy link
Member

overvenus commented Apr 9, 2024 •
edited
Loading

Can I be granted co-ownership of the brpb.proto, cdcpb.proto, configpb.proto and enginepb.proto files? I have written a significant portion of their content and understand the lessons learned from their development.

@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Apr 9, 2024

Can I be granted co-ownership of the brpb.proto, cdcpb.proto, configpb.proto and enginepb.proto files? I have written a significant portion of their content and understand the lessons learned from their development.

PTAL

@BornChanger
Copy link
Contributor

Can I be granted co-ownership of the brpb.proto, cdcpb.proto, configpb.proto and enginepb.proto files? I have written a significant portion of their content and understand the lessons learned from their development.
Sure.

@rleungx
Copy link
Member

rleungx commented Apr 9, 2024

proto/meta_storagepb.proto belongs to PD.

@wuhuizuo
chore: update OWNERS for proto files
dd951a0 
- add match pattern for `meta_storagepb.proto`, `configpb.proto`, `enginepb.proto`
- add "overvenus" to cdc and br SIG aliases.
@wuhuizuo
Merge branch 'master' into ci/add-owners-files
4303764
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Apr 9, 2024

updated in dd951a0
@rleungx @overvenus @flowbehappy @BornChanger PTAL

bb7133
bb7133 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuhuizuo
chore: update OWNERS for import_*pb.proto files
16101f4 
- add a new SIG `sig-approvers-pb-import` and add members: BornChanger, D3Hunter, lance6716.
- assign ``sig-approvers-pb-import` as the approver for `import_*pb.proto` proto files.
@wuhuizuo
Copy link
Contributor Author

/cc @Benjamin2037
PTAL 16101f4

Benjamin2037
Benjamin2037 approved these changes Apr 10, 2024
View reviewed changes
Copy link

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuhuizuo wuhuizuo merged commit 732e02a into master Apr 12, 2024
4 checks passed
@wuhuizuo wuhuizuo deleted the ci/add-owners-files branch April 12, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus left review comments

@bb7133 bb7133 bb7133 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@lance6716 lance6716 lance6716 approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@niubell niubell niubell approved these changes

@tonyxuqqi tonyxuqqi tonyxuqqi approved these changes

@you06 you06 you06 approved these changes

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

@BornChanger BornChanger BornChanger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup OWNERS files to control the approving for protobuf files