Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tls support for mysql client #186
base: master
Are you sure you want to change the base?
Add tls support for mysql client #186
Changes from 4 commits
e7cfc4b
52095d4
0c2b45d
c8dffdf
a7957cb
4b2c7db
9ad25f9
41368bb
56b6a64
7f4316b
3b8119a
aace302
58133ef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer https://docs.pingcap.com/tidb/stable/enable-tls-between-clients-and-servers#enable-authentication
If sslKey and sslCert are not provided, we will only authenticate the TiDB server from the MySQL client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think valid configurations are:
sslCA
providedsslCA
,sslCert
,sslKey
all provided.Not valid:
sslCert
and/orsslKey
set, but nosslCA
.sslCert
set, but notsslKey
sslKey
set, but notsslCert
So I think we should set the
tlsName
to custom if any ofsslCert
,sslKey
orsslCA
is set and then later on verify if it is valid (which might already be done)