Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Commit

Permalink
fix metaConn hold lock (#221)
Browse files Browse the repository at this point in the history
  • Loading branch information
lichunzhu authored Dec 24, 2020
1 parent 11d8d5d commit 0b4f03a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions v4/export/dump.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ func (d *Dumper) Dump() (dumpErr error) {
if err != nil {
return err
}
defer metaConn.Close()
m.recordStartTime(time.Now())
// for consistency lock, we can write snapshot info after all tables are locked.
// the binlog pos may changed because there is still possible write between we lock tables and write master status.
Expand Down

0 comments on commit 0b4f03a

Please sign in to comment.