ticdc: add vector type in output protocol (#20767) #20769
Conversation
ti-chi-bot
added
area/ticdc
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds support for the TiDBVectorFloat32 data type to several TiCDC output protocols, including Avro, Canal-JSON, CSV, Open Protocol, and Simple Protocol. The changes primarily involve updating the documentation to reflect the addition of this new data type and its corresponding representation in each protocol.
Highlights
- Feature: Adds support for the
TiDBVectorFloat32data type in TiCDC output protocols. - Documentation: Updates documentation for Avro, Canal-JSON, CSV, Open Protocol, and Simple Protocol to include information about the
TiDBVectorFloat32data type.
Changelog
- ticdc/ticdc-avro-protocol.md
- Added
TiDBVECTORFloat32to the table of column data formats, specifying its AVRO_TYPE as string.
- Added
- ticdc/ticdc-canal-json.md
- Added
TiDBVectorFloat32to the table, mapping it to Java SQL Type 12.
- Added
- ticdc/ticdc-csv.md
- Added
TiDBVectorFloat32to the table, specifying its string representation as"[1.23, -0.4]".
- Added
- ticdc/ticdc-open-protocol.md
- Added
TiDBVectorFloat32to the table, assigning it type code 225 and specifying its value representation as{"t":225,"v":"[1.23, -0.4]"}.
- Added
- ticdc/ticdc-simple-protocol.md
- Added
TiDBVectorFloat32to the table, mapping it to string for bothmysqlTypeand Avro schema definition.
- Added
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A vector's tale,
In data's vast domain,
Floats in protocols.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds support for the TiDBVectorFloat32 data type in the output protocol for TiCDC. The changes involve updating documentation files to reflect the new data type and its corresponding representation in different output formats (Avro, Canal-JSON, CSV, Open Protocol, and Simple Protocol). Overall, the changes seem straightforward and necessary to support the new data type.
Merge Readiness
The changes appear to be correct and necessary for supporting the TiDBVectorFloat32 data type in TiCDC's output protocol. I am unable to approve the pull request, and other reviewers should review and approve this code before merging. Given the nature of the changes (documentation updates), it seems reasonable to merge this pull request after addressing the review comments.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #20767
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?