tidb: mark the concurrently-init-stats config as deprecated #20758
Conversation
Signed-off-by: Rustin170506 <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @Rustin170506, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses the deprecation of the concurrently-init-stats configuration item in TiDB, which was deprecated in PR #60408. The change involves updating the tidb-configuration-file.md documentation file to reflect this deprecation, specifically by adding a warning indicating that starting from v9.0.0, the configuration item is deprecated and TiDB always initializes statistics concurrently during startup.
Highlights
- Deprecation Notice: The
concurrently-init-statsconfiguration item is marked as deprecated in the documentation. - Documentation Update: The
tidb-configuration-file.mdfile is updated to include a warning about the deprecation.
Changelog
- tidb-configuration-file.md
- Added a warning indicating that the
concurrently-init-statsconfiguration item is deprecated starting from v9.0.0. - The warning clarifies that TiDB always initializes statistics concurrently during startup from v9.0.0 onwards.
- Added a warning indicating that the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A config fades away,
No longer its role to play,
Stats now init,
Without a bit,
Concurrent from this day.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
missing-translation-status
There was a problem hiding this comment.
Code Review
The pull request deprecates the concurrently-init-stats configuration item in the TiDB documentation, which is a necessary step to reflect the changes in the TiDB codebase. The changes are straightforward and seem correct.
Summary of Findings
- Warning Message Clarity: The warning message added to the documentation could be more specific about the impact of the deprecation. It would be helpful to mention what users should do instead, if applicable.
Merge Readiness
The pull request is ready to be merged after addressing the clarity of the warning message. The change accurately reflects the deprecation of the configuration item, but adding more context to the warning would improve the user experience. I am unable to approve this pull request, and recommend that others review and approve this code before merging.
Signed-off-by: Rustin170506 <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tidb-configuration-file.md:617
- The default value information may be misleading since the config is deprecated in v9.1.0 and always enabled, regardless of the set value. Consider updating or clarifying this note to indicate that, from v9.1.0 onward, the configuration is ignored.
Default value: `false` for versions earlier than v8.2.0, `true` for v8.2.0 and later versions.
Oreoxmt
added
do-not-merge/hold
ti-chi-bot
bot
removed
the
missing-translation-status
Co-authored-by: Aolin <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@terry1purcell: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[LGTM Timeline notifier]Timeline:
|
Oreoxmt
added
the
translation/done
First-time contributors' checklist
What is changed, added or deleted? (Required)
This configuration was deprecated in pingcap/tidb#60408.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?