Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb cloud: add tidb node groups docs #19713

Merged
merged 40 commits into from
Dec 26, 2024
Merged

tidb cloud: add tidb node groups docs #19713

merged 40 commits into from
Dec 26, 2024

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Dec 16, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Dec 16, 2024
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2024
@hfxsd hfxsd added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. do-not-merge/blocked-paths and removed contribution This PR is from a community contributor. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. missing-translation-status This PR does not have translation status info. labels Dec 16, 2024
@hfxsd hfxsd marked this pull request as draft December 16, 2024 13:10
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 16, 2024
@hfxsd hfxsd marked this pull request as ready for review December 17, 2024 01:20
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024
@hfxsd hfxsd requested a review from qqqdan December 17, 2024 01:20
github-actions bot pushed a commit to hfxsd/pingcap-docsite-preview that referenced this pull request Dec 17, 2024
Preview PR pingcap/docs#19713 and this preview is triggered from commit
f1c5462 
pingcap/docs@796a53d
github-actions bot pushed a commit to hfxsd/pingcap-docsite-preview that referenced this pull request Dec 17, 2024
Preview PR pingcap/docs#19713 and this preview is triggered from commit
e32822c 
pingcap/docs@b013dae
github-actions bot pushed a commit to hfxsd/pingcap-docsite-preview that referenced this pull request Dec 17, 2024
Preview PR pingcap/docs#19713 and this preview is triggered from commit
7b8817b 
pingcap/docs@ce8b954
github-actions bot pushed a commit to hfxsd/pingcap-docsite-preview that referenced this pull request Dec 17, 2024
Preview PR pingcap/docs#19713 and this preview is triggered from commit
02193b2 
pingcap/docs@7b427af
@hfxsd hfxsd added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/blocked-paths labels Dec 25, 2024
Oreoxmt
Oreoxmt reviewed Dec 25, 2024
View reviewed changes
media/tidb-cloud/tidb-node-group-change-name.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this image

Oreoxmt
Oreoxmt reviewed Dec 25, 2024
View reviewed changes
media/tidb-cloud/tidb-node-group-table-view.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this image

Oreoxmt
Oreoxmt approved these changes Dec 25, 2024
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-25 08:09:26.622522596 +0000 UTC m=+1635556.711325136: ☑️ agreed by Oreoxmt.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 25, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 25, 2024

@qqqdan: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added lgtm and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 26, 2024
@hfxsd
Copy link
Collaborator Author

hfxsd commented Dec 26, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit ac40374 into pingcap:release-8.1 Dec 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qqqdan qqqdan qqqdan approved these changes

Assignees

@hfxsd hfxsd

Labels
approved area/tidb-cloud This PR relates to the area of TiDB Cloud. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hfxsd @Oreoxmt @qqqdan