Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud: update pause operation behavior for TiDB Cloud Dedicated clusters #19349

Merged
merged 7 commits into from
Nov 13, 2024
Merged

cloud: update pause operation behavior for TiDB Cloud Dedicated clusters #19349

merged 7 commits into from
Nov 13, 2024

Conversation

qqqdan
Copy link
Contributor

@qqqdan qqqdan commented Nov 6, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qqqdan qqqdan requested a review from Oreoxmt November 6, 2024 10:16
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 6, 2024
@Oreoxmt Oreoxmt self-assigned this Nov 6, 2024
@Oreoxmt Oreoxmt added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. labels Nov 6, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 6, 2024
@Oreoxmt Oreoxmt changed the title Update pause-or-resume-tidb-cluster.md cloud: update pause operation behavior for TiDB Cloud Dedicated clusters Nov 7, 2024
github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request Nov 7, 2024
Preview PR pingcap/docs#19349 and this preview is triggered from commit
44c7906 
pingcap/docs@df851c2
github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request Nov 7, 2024
Preview PR pingcap/docs#19349 and this preview is triggered from commit
dcd34c4 
pingcap/docs@57661b6
github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request Nov 7, 2024
Preview PR pingcap/docs#19349 and this preview is triggered from commit
bcbb483 
pingcap/docs@583b2bd
Oreoxmt
Oreoxmt reviewed Nov 11, 2024
View reviewed changes
tidb-cloud/pause-or-resume-tidb-cluster.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview: https://pingcap-docsite-preview-git-preview-cl-bd7c1b-oreoxmts-projects.vercel.app/tidbcloud/pause-or-resume-tidb-cluster

@lilin90 lilin90 self-requested a review November 11, 2024 07:43
lilin90
lilin90 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 11, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 11, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-11 08:08:40.657349518 +0000 UTC m=+257282.848218507: ☑️ agreed by lilin90.
  • 2024-11-11 10:26:46.262933229 +0000 UTC m=+265568.453802211: ☑️ agreed by Oreoxmt.

@Oreoxmt Oreoxmt added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed lgtm labels Nov 11, 2024
@Oreoxmt Oreoxmt mentioned this pull request Nov 12, 2024
Merged
16 tasks
@Oreoxmt Oreoxmt closed this Nov 12, 2024
@Oreoxmt Oreoxmt reopened this Nov 12, 2024
@Oreoxmt Oreoxmt added the lgtm label Nov 13, 2024
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 13, 2024

/approve
/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 13, 2024
@ti-chi-bot ti-chi-bot bot merged commit 72badba into release-7.5 Nov 13, 2024
13 of 14 checks passed
@Oreoxmt Oreoxmt deleted the pause-feature-update-202411 branch November 20, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@lilin90 lilin90 lilin90 approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qqqdan @Oreoxmt @lilin90