Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong-index-solution: update #19286

Merged
merged 7 commits into from
Dec 19, 2024
Merged

wrong-index-solution: update #19286

merged 7 commits into from
Dec 19, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Oct 31, 2024 •
edited by qiancai
Loading

What is changed, added or deleted? (Required)

The wrong index solution doc only focuses on one possible reason for why a different index than expected might be chosen. This update tries to extend this and also reference other helpful resources.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2024
@dveeden dveeden requested review from Oreoxmt, qiancai and mjonss October 31, 2024 06:56
@dveeden
Copy link
Contributor Author

dveeden commented Oct 31, 2024

Should we add something about Index Cardinality?

mjonss
mjonss approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I assume the referenced pages have examples and solutions to fix the issues, more than simply ANALYZE TABLE?

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2024

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM, and I assume the referenced pages have examples and solutions to fix the issues, more than simply ANALYZE TABLE?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden dveeden requested a review from qw4990 October 31, 2024 09:26
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 1, 2024

@qw4990: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai self-assigned this Dec 4, 2024
@qiancai qiancai added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Dec 4, 2024
qiancai
qiancai reviewed Dec 5, 2024
View reviewed changes
wrong-index-solution.md Outdated Show resolved Hide resolved
wrong-index-solution.md Outdated Show resolved Hide resolved
wrong-index-solution.md Outdated Show resolved Hide resolved
wrong-index-solution.md Outdated Show resolved Hide resolved
wrong-index-solution.md Outdated Show resolved Hide resolved
wrong-index-solution.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed Dec 13, 2024
View reviewed changes
wrong-index-solution.md Outdated Show resolved Hide resolved
wrong-index-solution.md Outdated Show resolved Hide resolved
@qiancai qiancai mentioned this pull request Dec 13, 2024
Merged
15 tasks
qiancai
qiancai reviewed Dec 13, 2024
View reviewed changes
wrong-index-solution.md Outdated Show resolved Hide resolved
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Dec 13, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 16, 2024
@hfxsd hfxsd self-requested a review December 16, 2024 03:23
@qiancai qiancai removed the request for review from Oreoxmt December 16, 2024 05:19
hfxsd
hfxsd reviewed Dec 16, 2024
View reviewed changes
wrong-index-solution.md Outdated Show resolved Hide resolved
wrong-index-solution.md Outdated Show resolved Hide resolved
wrong-index-solution.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 16, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-16 03:11:47.647031571 +0000 UTC m=+840097.735834114: ☑️ agreed by qiancai.
  • 2024-12-16 14:14:45.316685755 +0000 UTC m=+879875.405488295: ☑️ agreed by hfxsd.

dveeden and others added 3 commits December 16, 2024 15:38
@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Dec 19, 2024
@qiancai
Copy link
Collaborator

qiancai commented Dec 19, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 19, 2024
This was referenced Dec 19, 2024
Merged
Merged
@ti-chi-bot ti-chi-bot bot merged commit fda8852 into pingcap:master Dec 19, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19729.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 19, 2024
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19730.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 19, 2024
Merged
15 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 19, 2024
@ti-chi-bot
wrong-index-solution: update (#19286) (#19730)
e0062c9
ti-chi-bot bot pushed a commit that referenced this pull request Dec 19, 2024
@ti-chi-bot
wrong-index-solution: update (#19286) (#19729)
117caaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@hfxsd hfxsd hfxsd approved these changes

@qw4990 qw4990 qw4990 approved these changes

@mjonss mjonss mjonss approved these changes

Assignees

@qiancai qiancai

Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dveeden @qiancai @ti-chi-bot @mjonss @qw4990 @hfxsd