Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add tidb_enable_stats_owner #19109

Merged
merged 6 commits into from
Oct 31, 2024
Merged

*: add tidb_enable_stats_owner #19109

merged 6 commits into from
Oct 31, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Oct 14, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:

pingcap/docs-cn#18817

  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 14, 2024
@hawkingrei hawkingrei mentioned this pull request Oct 14, 2024
Merged
16 tasks
songrijie
songrijie reviewed Oct 14, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
songrijie
songrijie approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@songrijie songrijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 14, 2024

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

rest LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. for-release This PR relates to a TiDB release but does not have a tracked feature. v8.4 This PR/issue applies to TiDB v8.4. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Oct 15, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Oct 15, 2024
@Oreoxmt Oreoxmt self-requested a review October 15, 2024 10:06
@Oreoxmt Oreoxmt self-assigned this Oct 15, 2024
Oreoxmt
Oreoxmt reviewed Oct 22, 2024
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 22, 2024
Oreoxmt
Oreoxmt reviewed Oct 22, 2024
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. label Oct 22, 2024
qiancai
qiancai approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 28, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-22 07:31:51.41169934 +0000 UTC m=+336312.108489947: ☑️ agreed by Oreoxmt.
  • 2024-10-28 06:31:17.922184257 +0000 UTC m=+244990.761339803: ☑️ agreed by qiancai.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 30, 2024

/approve
/unold

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 30, 2024
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 31, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2024
@ti-chi-bot ti-chi-bot bot merged commit 111803a into pingcap:master Oct 31, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19259.

This was referenced Oct 31, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Oct 31, 2024
@ti-chi-bot
*: add tidb_enable_stats_owner (#19109) (#19259)
c1b373c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qiancai qiancai qiancai approved these changes

@songrijie songrijie songrijie approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hawkingrei @Oreoxmt @ti-chi-bot @songrijie @qiancai