Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in DM best practices #18918

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

alastori
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Fixing broken link. It was [Use the relay log](#use-the relay-log). Changed to Use the relay log.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Sorry, something went wrong.

@ti-chi-bot ti-chi-bot bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2024
@alastori
Copy link
Contributor Author

/label needs-cherry-pick-release-8.4
/label needs-cherry-pick-release-8.3
/label needs-cherry-pick-release-8.2
/label needs-cherry-pick-release-8.1
/label needs-cherry-pick-release-7.5
/label needs-cherry-pick-release-7.1
/label needs-cherry-pick-release-6.5

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Sep 18, 2024
Copy link

ti-chi-bot bot commented Sep 18, 2024

@alastori: The label(s) needs-cherry-pick-release-8.4, needs-cherry-pick-release-8.2 cannot be applied. These labels are supported: 2024-tidb-docs-dash, contribution, first-time-contributor, for-future-release, good first issue, hacktoberfest-accepted, Hacktoberfest, help wanted, needs-cherry-pick-master, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-cherry-pick-release-8.1, needs-cherry-pick-release-8.3, question, requires-followup, requires-version-specific-changes, special-week, website.

In response to this:

/label needs-cherry-pick-release-8.4
/label needs-cherry-pick-release-8.3
/label needs-cherry-pick-release-8.2
/label needs-cherry-pick-release-8.1
/label needs-cherry-pick-release-7.5
/label needs-cherry-pick-release-7.1
/label needs-cherry-pick-release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lilin90 lilin90 self-assigned this Sep 18, 2024
@lilin90 lilin90 added the translation/no-need No need to translate this PR. label Sep 18, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 18, 2024
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 18, 2024
Copy link

ti-chi-bot bot commented Sep 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-18 02:00:21.003140608 +0000 UTC m=+1012890.743564566: ☑️ agreed by lilin90.

@lilin90 lilin90 added the lgtm label Sep 18, 2024
@lilin90
Copy link
Member

lilin90 commented Sep 18, 2024

/approve

Copy link

ti-chi-bot bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 18, 2024
@ti-chi-bot ti-chi-bot bot merged commit f6ef460 into pingcap:master Sep 18, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #18919.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #18920.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #18921.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18922.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #18923.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #18924.

ti-chi-bot bot pushed a commit that referenced this pull request Sep 18, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
ti-chi-bot bot pushed a commit that referenced this pull request Sep 18, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
ti-chi-bot bot pushed a commit that referenced this pull request Sep 18, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
ti-chi-bot bot pushed a commit that referenced this pull request Sep 18, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
ti-chi-bot bot pushed a commit that referenced this pull request Sep 18, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
ti-chi-bot bot pushed a commit that referenced this pull request Sep 18, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants