stats, sql: fix format and update wording #18192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilin90
added
needs-cherry-pick-release-8.1
ti-chi-bot
bot
added
the
size/M
dveeden
approved these changes
Jul 11, 2024
| @@ -148,13 +148,13 @@ If a table has many columns, collecting statistics on all the columns can cause | |||
|
|
|||
| <CustomContent platform="tidb"> | |||
|
|
|||
| After the setting, TiDB writes the `PREDICATE COLUMNS` information to the `mysql.column_stats_usage` system table every 100 * [`stats-lease`](/tidb-configuration-file.md#stats-lease). | |||
| After the setting, TiDB writes the `PREDICATE COLUMNS` information to the [`mysql.column_stats_usage`](/mysql-schema.md#statistics-system-tables) system table every 100 * [`stats-lease`](/tidb-configuration-file.md#stats-lease). | |||
There was a problem hiding this comment.
The docs for the mysql schema could be improved:
- One page per table, just like
information_schemaetc. - Add field explanations for TiDB
mysqlschema tables #16684
But this doesn't need to be fixed in this PR
|
qiancai
reviewed
Jul 15, 2024
Co-authored-by: Grace Cai <[email protected]>
|
@qiancai All the comments have been addressed. PTAL again~ Thanks! |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Co-authored-by: Grace Cai <[email protected]>
ti-chi-bot
bot
removed
the
size/M
ti-chi-bot
bot
added
the
size/L
lilin90
commented
Jul 19, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
17 tasks
|
In response to a cherrypick label: new pull request created to branch |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
When I was creating pingcap/docs-cn#17827, I found some issues in the English version. So I created this PR to:
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?