Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend CAST and multi-valued-index docs #17472

Merged
merged 7 commits into from
May 17, 2024
Merged

Extend CAST and multi-valued-index docs #17472

merged 7 commits into from
May 17, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented May 13, 2024

What is changed, added or deleted? (Required)

  • Add more links
  • Update CAST() docs

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested a review from qiancai May 13, 2024 06:58
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 13, 2024
@dveeden dveeden requested a review from YangKeao May 13, 2024 06:58
YangKeao
YangKeao approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 13, 2024

@YangKeao: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM 👍

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. labels May 15, 2024
@qiancai qiancai self-assigned this May 15, 2024
@qiancai qiancai added translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-8.0 labels May 15, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 15, 2024
@qiancai qiancai added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label May 15, 2024
qiancai
qiancai approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

functions-and-operators/cast-functions-and-operators.md Outdated Show resolved Hide resolved
functions-and-operators/cast-functions-and-operators.md Outdated Show resolved Hide resolved
functions-and-operators/cast-functions-and-operators.md Outdated Show resolved Hide resolved
functions-and-operators/cast-functions-and-operators.md Outdated Show resolved Hide resolved
functions-and-operators/cast-functions-and-operators.md Outdated Show resolved Hide resolved
functions-and-operators/cast-functions-and-operators.md Outdated Show resolved Hide resolved
functions-and-operators/cast-functions-and-operators.md Outdated Show resolved Hide resolved
functions-and-operators/cast-functions-and-operators.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 15, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 16, 2024

@qiancai: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai mentioned this pull request May 16, 2024
Merged
16 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels May 16, 2024
@qiancai qiancai requested a review from Oreoxmt May 16, 2024 02:29
Oreoxmt
Oreoxmt approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 16, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-15 10:02:43.161378796 +0000 UTC m=+1647516.918514369: ☑️ agreed by qiancai.
  • 2024-05-16 03:28:22.788401304 +0000 UTC m=+1710256.545536877: ☑️ agreed by Oreoxmt.

@qiancai
Copy link
Collaborator

qiancai commented May 17, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 17, 2024
This was referenced May 17, 2024
Merged
Merged
@ti-chi-bot ti-chi-bot bot merged commit 13fa816 into pingcap:master May 17, 2024
9 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request May 17, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17527.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request May 17, 2024
@dveeden @ti-chi-bot
Extend CAST and multi-valued-index docs (pingcap#17472)
bd28702
@ti-chi-bot ti-chi-bot mentioned this pull request May 17, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #17528.

ti-chi-bot bot pushed a commit that referenced this pull request May 20, 2024
@ti-chi-bot
Extend CAST and multi-valued-index docs (#17472) (#17528)
0cbc42c
ti-chi-bot bot pushed a commit that referenced this pull request May 20, 2024
@ti-chi-bot
Extend CAST and multi-valued-index docs (#17472) (#17527)
ab0bf3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees

@qiancai qiancai

Labels
approved area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dveeden @qiancai @ti-chi-bot @YangKeao @Oreoxmt