Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and correct information aboud sys.schema_unused_indexes #16885

Merged
merged 9 commits into from
Mar 29, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Mar 28, 2024

What is changed, added or deleted? (Required)

  1. Information about sys and sys.schema_unused_indexes was not separated like we do for other system schemas
  2. Some places refered to sys.schema_unused_index instead of sys.schema_unused_indexes
  3. The sys.schema_unused_indexes info and INFORMATION_SCHEMA.TIDB_INDEX_USAGE didn't link to each other.
  4. The sys info wasn't in the TiDB Cloud TOC

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from YangKeao, hfxsd and qiancai March 28, 2024 08:44
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2024
@dveeden dveeden requested a review from Oreoxmt March 28, 2024 08:44
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Mar 28, 2024

@YangKeao: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

TOC-tidb-cloud.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
information-schema/information-schema-tidb-index-usage.md Outdated Show resolved Hide resolved
sys-schema/schema_unused_indexes.md Outdated Show resolved Hide resolved
releases/release-8.0.0.md Outdated Show resolved Hide resolved
releases/release-8.0.0.md Outdated Show resolved Hide resolved
sys-schema/schema_unused_indexes.md Outdated Show resolved Hide resolved
sys-schema/schema_unused_indexes.md Outdated Show resolved Hide resolved
sys-schema/sys-schema.md Outdated Show resolved Hide resolved
sys-schema/sys-schema.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt added translation/doing This PR's assignee is translating this PR. v8.0 labels Mar 28, 2024
@Oreoxmt Oreoxmt self-assigned this Mar 28, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 28, 2024
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-8.0 and removed translation/doing This PR's assignee is translating this PR. labels Mar 28, 2024
@Oreoxmt Oreoxmt removed the request for review from qiancai March 28, 2024 09:34
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2024
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 28, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 28, 2024
Copy link

ti-chi-bot bot commented Mar 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-28 10:04:19.834313961 +0000 UTC m=+2148686.856560349: ☑️ agreed by Oreoxmt.
  • 2024-03-28 11:02:33.466868913 +0000 UTC m=+2152180.489115298: ☑️ agreed by hfxsd.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 29, 2024

/approve

Copy link

ti-chi-bot bot commented Mar 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8e6656f into pingcap:master Mar 29, 2024
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #16902.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants