Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rehash of statistics page #16869

Merged
merged 36 commits into from
Apr 16, 2024
Merged

Rehash of statistics page #16869

merged 36 commits into from
Apr 16, 2024

Conversation

terry1purcell
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Improved readability of the statistics page. Including clarification of the different statistics.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 27, 2024
Copy link

ti-chi-bot bot commented Mar 27, 2024

Hi @terry1purcell. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 27, 2024
statistics.md Show resolved Hide resolved
Copy link
Contributor

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few places could use links to the SQL statements (mostly places related to loading and exporting statistics)

The "copyable" lines can all be removed iirc.

There are a few 'sqlgram' uses. Would be best to replace them with the new EBNF things. #4389

statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Show resolved Hide resolved
@dveeden dveeden requested a review from mjonss April 2, 2024 07:01
@dveeden
Copy link
Contributor

dveeden commented Apr 2, 2024

Adding @mjonss as reviewer for the parts that are related to partitioning.

@terry1purcell terry1purcell requested a review from dveeden April 3, 2024 17:04
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 3, 2024
@dveeden dveeden requested review from hfxsd, Oreoxmt and qiancai April 8, 2024 05:06
@Oreoxmt Oreoxmt removed their request for review April 8, 2024 05:49
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 15, 2024

@winoros: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

statistics.md Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lilin90
Copy link
Member

lilin90 commented Apr 16, 2024

/test pull-verify

@lilin90
Copy link
Member

lilin90 commented Apr 16, 2024

/retest

statistics.md Outdated Show resolved Hide resolved
@lilin90
Copy link
Member

lilin90 commented Apr 16, 2024

/approve

Copy link

ti-chi-bot bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 16, 2024
@lilin90 lilin90 self-assigned this Apr 16, 2024
@lilin90
Copy link
Member

lilin90 commented Apr 16, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 16, 2024
@ti-chi-bot ti-chi-bot bot merged commit 2c4e651 into pingcap:master Apr 16, 2024
9 checks passed
@lilin90 lilin90 added the type/enhancement The issue or PR belongs to an enhancement. label Apr 16, 2024
dveeden pushed a commit to dveeden/docs that referenced this pull request May 15, 2024
@terry1purcell terry1purcell deleted the statsupdate branch May 28, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution This PR is from a community contributor. lgtm ok-to-test Indicates a PR is ready to be tested. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/doing This PR's assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants