Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miscellaneous-functions: Update reference manual #16855

Merged
merged 7 commits into from
Apr 23, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Mar 26, 2024

What is changed, added or deleted? (Required)

Closes #16816

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 26, 2024
@dveeden dveeden requested review from mjonss and qiancai March 26, 2024 13:21
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor suggestions.

functions-and-operators/miscellaneous-functions.md Outdated Show resolved Hide resolved
functions-and-operators/miscellaneous-functions.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Mar 26, 2024

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM, with some minor suggestions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden dveeden requested a review from bb7133 March 29, 2024 08:23
@qiancai qiancai self-assigned this Apr 8, 2024
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Apr 8, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Apr 8, 2024
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 16, 2024

@bb7133: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai
Copy link
Collaborator

qiancai commented Apr 19, 2024

Hi @dveeden, I've submitted 639a396 for description updates. PTAL. Thanks.

@dveeden
Copy link
Contributor Author

dveeden commented Apr 19, 2024

Hi @dveeden, I've submitted 639a396 for description updates. PTAL. Thanks.

This looks good. Maybe we should start to add argument descriptions. E.g. SLEEP(seconds) instead of SLEEP(), but that can also be done at a later moment.

@qiancai
Copy link
Collaborator

qiancai commented Apr 23, 2024

Hi @dveeden, I've submitted 639a396 for description updates. PTAL. Thanks.

This looks good. Maybe we should start to add argument descriptions. E.g. SLEEP(seconds) instead of SLEEP(), but that can also be done at a later moment.

Yes, as most functions in this doc look straightforward, we could consider adding these argument descriptions later.

@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-8.0 and removed translation/doing This PR's assignee is translating this PR. labels Apr 23, 2024
@Oreoxmt Oreoxmt self-requested a review April 23, 2024 08:04
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 23, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 23, 2024
Copy link

ti-chi-bot bot commented Apr 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-23 09:47:46.395252905 +0000 UTC m=+80823.135155812: ☑️ agreed by Oreoxmt.
  • 2024-04-23 09:49:38.814971048 +0000 UTC m=+80935.554873980: ☑️ agreed by qiancai.

@qiancai
Copy link
Collaborator

qiancai commented Apr 23, 2024

/approve

Copy link

ti-chi-bot bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 23, 2024
@ti-chi-bot ti-chi-bot bot merged commit e95cc3b into pingcap:master Apr 23, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17320.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update reference manual links in functions-and-operators/miscellaneous-functions.md
6 participants