Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encryption-and-compression-functions: Update for MySQL 8.0 #16852

Merged
merged 4 commits into from
Apr 18, 2024
Merged

encryption-and-compression-functions: Update for MySQL 8.0 #16852

merged 4 commits into from
Apr 18, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Mar 26, 2024

What is changed, added or deleted? (Required)

Closes #16819

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from mjonss and qiancai March 26, 2024 10:18
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2024
mjonss
mjonss approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor questions.

functions-and-operators/encryption-and-compression-functions.md Outdated Show resolved Hide resolved
functions-and-operators/encryption-and-compression-functions.md Outdated

## MySQL Compatibility

* TiDB doesn't support the `STATEMENT_DIGEST()` and `STATEMENT_DIGEST_TEXT()` functions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create an issue in tidb repository for adding these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's needed. But I'm also not against it...

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 26, 2024

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM, with some minor questions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden dveeden requested a review from bb7133 March 29, 2024 08:24
@qiancai qiancai self-assigned this Apr 8, 2024
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Apr 8, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Apr 8, 2024
bb7133
bb7133 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 16, 2024

@bb7133: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qiancai
qiancai approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

functions-and-operators/encryption-and-compression-functions.md Outdated Show resolved Hide resolved
functions-and-operators/encryption-and-compression-functions.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 17, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-17 01:48:40.04363635 +0000 UTC m=+389139.154682800: ☑️ agreed by qiancai.

@qiancai
Copy link
Collaborator

qiancai commented Apr 18, 2024

/approve

@qiancai qiancai added the lgtm label Apr 18, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 18, 2024
@ti-chi-bot ti-chi-bot bot merged commit 4f600af into pingcap:master Apr 18, 2024
9 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 18, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17248.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 19, 2024
@ti-chi-bot
encryption-and-compression-functions: Update for MySQL 8.0 (#16852) (#…
001f89f 
…17248)
@qiancai qiancai mentioned this pull request Apr 26, 2024
Merged
17 tasks
@qiancai qiancai removed the translation/doing This PR's assignee is translating this PR. label Apr 26, 2024
@qiancai qiancai added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Apr 26, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 29, 2024
Merged
17 tasks
dveeden added a commit to dveeden/docs that referenced this pull request May 15, 2024
@dveeden
encryption-and-compression-functions: Update for MySQL 8.0 (pingcap#1…
5e7abfb 
…6852)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@mjonss mjonss mjonss approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees

@qiancai qiancai

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update reference manual links in functions-and-operators/encryption-and-compression-functions.md
5 participants
@dveeden @qiancai @ti-chi-bot @bb7133 @mjonss