Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choose-index: update the docs for supporting more patterns for mv index #16788

Merged
merged 12 commits into from
Mar 27, 2024

Conversation

time-and-fate
Copy link
Member

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 20, 2024
@hfxsd hfxsd self-assigned this Mar 20, 2024
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.0 and removed missing-translation-status This PR does not have translation status info. labels Mar 20, 2024
@hfxsd hfxsd requested a review from songrijie March 20, 2024 06:03
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested a review from AilinKid March 21, 2024 01:49
choose-index.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested review from Oreoxmt and removed request for Oreoxmt March 22, 2024 03:19
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated
+-------------------------------+---------+-----------+-----------------------------------------------------------------------------+---------------------------------------------+
```

- If both `OR` and `AND` appear in the conditions (nested `OR` and `AND`), the conditions that constitute the IndexMerge must all match the semantic of `OR` or the semantic of `AND`, and they cannot make part of them match the semantic of `OR` while the others match the semantic of `AND`. For example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"they cannot make part of them match the semantic of OR while the others match the semantic" we can improve this

choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Mar 26, 2024

@AilinKid: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

choose-index.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Mar 26, 2024

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd requested a review from Oreoxmt March 26, 2024 14:20
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested review from qiancai and removed request for Oreoxmt March 27, 2024 02:27
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
choose-index.md Outdated Show resolved Hide resolved
@hfxsd
Copy link
Collaborator

hfxsd commented Mar 27, 2024

/approve

Copy link

ti-chi-bot bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 27, 2024
@hfxsd hfxsd added the lgtm label Mar 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 0d22430 into pingcap:master Mar 27, 2024
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #16865.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants